This repository was archived by the owner on Sep 30, 2022. It is now read-only.
  
  
  - 
                Notifications
    You must be signed in to change notification settings 
- Fork 68
Patchs on osc portals4 #1280
          
     Merged
      
      
    
                
     Merged
            
            Patchs on osc portals4 #1280
Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    …e right ID is allocated
… the appropriate format to display it.
…or ompi_osc_portals4_get_op() returns an error
…r bound before calling portals4
| :bot:assign: @tkordenbrock | 
| @PDeveze: Sorry, only this repo's organization members can interact with this bot. If you're a member of this organization, make your membership public so that this bot can verify your membership (go to http://github.com/orgs/open-mpi/people, find yourself on that page, then change your membership from "Private" to "Public"). | 
| :bot:assign: @tkordenbrock | 
| Test PASSed. | 
| This PR looks good. 👍 | 
  
      Sign up for free
      to subscribe to this conversation on GitHub.
      Already have an account?
      Sign in.
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
This set of patchs mainly splits Get and Put because portals4 may impose size restriction. It takes into account the lower bound of buffer before calling portals4. It also verifies that an ME is operational by waiting the EVENT_LINK. The other changes are minor changes (display, format, better check in PTAlloc, use of uid from GetUid, set the value of req_status.MPI_ERROR to MPI_SUCCESS, Store the no_locks parameter in osc_portals4_component.no_locks and correction in an if statement).